Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Fixup CI Readme badge #305

Merged
merged 2 commits into from
May 9, 2024
Merged

[DOC] Fixup CI Readme badge #305

merged 2 commits into from
May 9, 2024

Conversation

mikaelarguedas
Copy link
Member

@mikaelarguedas mikaelarguedas commented May 8, 2024

github action badge not displaying actual status because not pointing to the right branch.

Screenshot from 2024-05-08 19-13-07

With this change it's displaying the status of the rolling branch and not the status of the last job ran

@mikaelarguedas mikaelarguedas marked this pull request as ready for review May 8, 2024 17:55
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.35%. Comparing base (0b6ac75) to head (cb03560).

Additional details and impacted files
@@           Coverage Diff            @@
##           rolling     #305   +/-   ##
========================================
  Coverage    77.35%   77.35%           
========================================
  Files           25       25           
  Lines          627      627           
  Branches        66       66           
========================================
  Hits           485      485           
  Misses         121      121           
  Partials        21       21           
Flag Coverage Δ
unittests 77.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github action badge not displaying actual status because not pointing to
the right branch.
When adding the parameter to poitn it to the right branch it can't
retrieve the status

Signed-off-by: Mikael Arguedas <[email protected]>
@mikaelarguedas mikaelarguedas changed the title switch back to shields.io for CI status image Fixup CI Readme badge May 8, 2024
@mikaelarguedas mikaelarguedas changed the title Fixup CI Readme badge [DOC] Fixup CI Readme badge May 8, 2024
@mikaelarguedas mikaelarguedas merged commit 3882441 into rolling May 9, 2024
7 checks passed
@mikaelarguedas mikaelarguedas deleted the fix_readme_badge branch May 9, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant